Added a repository field to the Metadata struct (fixes #77) #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this repo no longer satisfies its own MSRV because the Compiler errors with Rust 1.36.0$ cargo +1.36.0 test
...
error: cannot find macro `matches!` in this scope
--> /home/michael/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-demangle-0.1.21/src/v0.rs:700:20
|
700 | if matches!((quote, c), ('\'', '"') | ('"', '\'')) {
| ^^^^^^^
error: aborting due to previous error
error: Could not compile `rustc-demangle`.
warning: build failed, waiting for other jobs to finish...
error[E0658]: naming constants with `_` is unstable
--> /home/michael/.cargo/registry/src/github.com-1ecc6299db9ec823/memchr-2.4.1/src/memmem/prefilter/fallback.rs:37:1
|
37 | const _: PrefilterFnTy = find;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see https://github.com/rust-lang/rust/issues/54912
error[E0658]: naming constants with `_` is unstable
--> /home/michael/.cargo/registry/src/github.com-1ecc6299db9ec823/memchr-2.4.1/src/memmem/prefilter/x86/sse.rs:9:1
|
9 | const _: PrefilterFnTy = find;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see https://github.com/rust-lang/rust/issues/54912
error[E0658]: non exhaustive is an experimental feature
--> /home/michael/.cargo/registry/src/github.com-1ecc6299db9ec823/memchr-2.4.1/src/memmem/prefilter/mod.rs:152:1
|
152 | #[non_exhaustive]
| ^^^^^^^^^^^^^^^^^
|
= note: for more information, see https://github.com/rust-lang/rust/issues/44109
error: aborting due to 3 previous errorsI've created #79 to track this. |
Michael-F-Bryan
force-pushed
the
repository-link
branch
from
8fda54f
to
8fbfe99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose one: this is a 🙋 feature
This resolves #77 by adding a
repositoryfield to theMetadatastruct and a corresponding "Repository: ..." line to the message that gets printedChecklist
Context
See #77.
Semver Changes
This is a breaking change because it adds a field to
Metadata, which doesn't have the#[non_exhaustive]attribute.